Skip to content

Fix NinjaOne queries returning no data, and make ts a working timeframe filter #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Deenk wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix NinjaOne queries returning no data, and make ts a working timeframe filter #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c61dc7c
Fix NinjaOne queries returning no data, and make ts a working timefra…
Deenk Sep 10, 2026
31e67b0
Withdraw closed historical timeframes that ts cannot bound
Deenk Sep 10, 2026
4238fc5
Offer every timeframe the NinjaOne endpoints can actually support
Deenk Sep 11, 2026
0cd9b3f
Label the query timestamp "Collected At", not "Last Updated"
Deenk Sep 14, 2026
0cdd41c
Merge branch 'main' into work/dw/ninjaone-ts-filter
Deenk Sep 14, 2026
c515d5b
Convert the query epoch timestamps to ISO 8601, and label them "Colle…
Deenk Sep 14, 2026
f0f7ec8
Stop activities applying a silent 24-hour window at "None"
Deenk Sep 14, 2026
eec714b
Stop tickets applying a silent 24-hour window at "None"
Deenk Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions plugins/NinjaOne/v1/dataStreams/activities.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@
"getArgs": [
{
"key": "after",
"value": "{{timeframe.start}}"
"value": "{{typeof timeframe === 'undefined' || timeframe.enum === 'none' ? null : timeframe.start}}"
},
{
"key": "before",
"value": "{{timeframe.end}}"
"value": "{{typeof timeframe === 'undefined' || timeframe.enum === 'none' ? null : timeframe.end}}"
},
{
"key": "pageSize",
Expand Down Expand Up @@ -110,5 +110,6 @@
"lastQuarter",
"lastYear",
"none"
]
],
"supportsNoneTimeframe": true
}
12 changes: 7 additions & 5 deletions plugins/NinjaOne/v1/dataStreams/antivirusStatus.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "antivirusStatus",
"displayName": "Antivirus Status",
"tags": ["Security"],
"description": "Antivirus product status and definition updates",
"description": "Antivirus product status and definition updates (timeframe filters on when each record was last collected)",
"baseDataSourceName": "httpRequestUnscoped",
"config": {
"httpMethod": "get",
Expand All @@ -24,11 +24,11 @@
},
"expandInnerObjects": false,
"endpointPath": "/v2/queries/antivirus-status",
"pathToData": "results",
"postRequestScript": "collectionWindow.js",
"getArgs": [
{
"key": "ts",
"value": "{{timeframe.end}}"
"value": "{{typeof timeframe === 'undefined' || timeframe.enum === 'none' || timeframe.unixStart == null ? null : 'after ' + timeframe.unixStart}}"
Comment thread
clarkd marked this conversation as resolved.
}
],
"headers": []
Expand Down Expand Up @@ -74,7 +74,7 @@
},
{
"name": "timestamp",
"displayName": "Last Updated",
"displayName": "Collection Time",
"shape": [
"date",
{
Expand All @@ -99,5 +99,7 @@
"lastQuarter",
"lastYear",
"none"
]
],
"supportsNoneTimeframe": true,
"defaultTimeframe": "none"
}
20 changes: 16 additions & 4 deletions plugins/NinjaOne/v1/dataStreams/antivirusThreats.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "antivirusThreats",
"displayName": "Antivirus Threats",
"tags": ["Security"],
"description": "Detected antivirus threats with quarantine status",
"description": "Detected antivirus threats with quarantine status (timeframe filters on when each record was last collected)",
"baseDataSourceName": "httpRequestUnscoped",
"config": {
"httpMethod": "get",
Expand All @@ -24,11 +24,11 @@
},
"expandInnerObjects": false,
"endpointPath": "/v2/queries/antivirus-threats",
"pathToData": "results",
"postRequestScript": "collectionWindow.js",
"getArgs": [
{
"key": "ts",
"value": "{{timeframe.end}}"
"value": "{{typeof timeframe === 'undefined' || timeframe.enum === 'none' || timeframe.unixStart == null ? null : 'after ' + timeframe.unixStart}}"
}
],
"headers": []
Expand Down Expand Up @@ -98,6 +98,16 @@
"displayName": "Action Taken",
"shape": "string"
},
{
"name": "timestamp",
"displayName": "Collection Time",
"shape": [
"date",
{
"timeZone": "Etc/UTC"
}
]
},
{
"pattern": ".*"
}
Expand All @@ -115,5 +125,7 @@
"lastQuarter",
"lastYear",
"none"
]
],
"supportsNoneTimeframe": true,
"defaultTimeframe": "none"
}
5 changes: 3 additions & 2 deletions plugins/NinjaOne/v1/dataStreams/backupJobs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"getArgs": [
{
"key": "stf",
"value": "startTime after {{timeframe.start}}"
"value": "{{typeof timeframe === 'undefined' || timeframe.enum === 'none' || timeframe.start == null || timeframe.end == null ? null : 'startTime between ' + timeframe.start + ' and ' + timeframe.end}}"
}
],
"headers": []
Expand Down Expand Up @@ -178,5 +178,6 @@
"lastQuarter",
"lastYear",
"none"
]
],
"supportsNoneTimeframe": true
}
20 changes: 16 additions & 4 deletions plugins/NinjaOne/v1/dataStreams/computerSystems.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "computerSystems",
"displayName": "Computer Systems",
"tags": ["Monitoring"],
"description": "Hardware information including manufacturer, model, and serial number",
"description": "Hardware information including manufacturer, model, and serial number (timeframe filters on when each record was last collected)",
"baseDataSourceName": "httpRequestUnscoped",
"config": {
"httpMethod": "get",
Expand All @@ -24,11 +24,11 @@
},
"expandInnerObjects": false,
"endpointPath": "/v2/queries/computer-systems",
"pathToData": "results",
"postRequestScript": "collectionWindow.js",
"getArgs": [
{
"key": "ts",
"value": "{{timeframe.end}}"
"value": "{{typeof timeframe === 'undefined' || timeframe.enum === 'none' || timeframe.unixStart == null ? null : 'after ' + timeframe.unixStart}}"
}
],
"headers": []
Expand Down Expand Up @@ -77,6 +77,16 @@
"displayName": "Workgroup",
"shape": "string"
},
{
"name": "timestamp",
"displayName": "Collection Time",
"shape": [
"date",
{
"timeZone": "Etc/UTC"
}
]
},
{
"pattern": ".*"
}
Expand All @@ -94,5 +104,7 @@
"lastQuarter",
"lastYear",
"none"
]
],
"supportsNoneTimeframe": true,
"defaultTimeframe": "none"
}
20 changes: 16 additions & 4 deletions plugins/NinjaOne/v1/dataStreams/disksGlobal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "disksGlobal",
"displayName": "Devices (Disks Global)",
"tags": ["Monitoring"],
"description": "Physical disk inventory with SMART status across all devices",
"description": "Physical disk inventory with SMART status across all devices (timeframe filters on when each record was last collected)",
"baseDataSourceName": "httpRequestUnscoped",
"config": {
"httpMethod": "get",
Expand All @@ -24,11 +24,11 @@
},
"expandInnerObjects": false,
"endpointPath": "/v2/queries/disks",
"pathToData": "results",
"postRequestScript": "collectionWindow.js",
"getArgs": [
{
"key": "ts",
"value": "{{timeframe.end}}"
"value": "{{typeof timeframe === 'undefined' || timeframe.enum === 'none' || timeframe.unixStart == null ? null : 'after ' + timeframe.unixStart}}"
}
],
"headers": []
Expand Down Expand Up @@ -102,6 +102,16 @@
}
]
},
{
"name": "timestamp",
"displayName": "Collection Time",
"shape": [
"date",
{
"timeZone": "Etc/UTC"
}
]
},
{
"pattern": ".*"
}
Expand All @@ -119,5 +129,7 @@
"lastQuarter",
"lastYear",
"none"
]
],
"supportsNoneTimeframe": true,
"defaultTimeframe": "none"
}
22 changes: 2 additions & 20 deletions plugins/NinjaOne/v1/dataStreams/networkInterfacesGlobal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,7 @@
"expandInnerObjects": true,
"endpointPath": "/v2/queries/network-interfaces",
"pathToData": "results",
"getArgs": [
{
"key": "ts",
"value": "{{timeframe.end}}"
}
],
"getArgs": [],
"headers": []
},
"metadata": [
Expand Down Expand Up @@ -116,18 +111,5 @@
"pattern": ".*"
}
],
"timeframes": [
"last1hour",
"last12hours",
"last24hours",
"last7days",
"last30days",
"thisMonth",
"thisQuarter",
"thisYear",
"lastMonth",
"lastQuarter",
"lastYear",
"none"
]
"timeframes": false
}
20 changes: 16 additions & 4 deletions plugins/NinjaOne/v1/dataStreams/operatingSystems.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "operatingSystems",
"displayName": "Devices (Operating Systems)",
"tags": ["Monitoring"],
"description": "OS details with reboot requirements",
"description": "OS details with reboot requirements (timeframe filters on when each record was last collected)",
"baseDataSourceName": "httpRequestUnscoped",
"config": {
"httpMethod": "get",
Expand All @@ -24,11 +24,11 @@
},
"expandInnerObjects": false,
"endpointPath": "/v2/queries/operating-systems",
"pathToData": "results",
"postRequestScript": "collectionWindow.js",
"getArgs": [
{
"key": "ts",
"value": "{{timeframe.end}}"
"value": "{{typeof timeframe === 'undefined' || timeframe.enum === 'none' || timeframe.unixStart == null ? null : 'after ' + timeframe.unixStart}}"
}
],
"headers": []
Expand Down Expand Up @@ -92,6 +92,16 @@
}
]
},
{
"name": "timestamp",
"displayName": "Collection Time",
"shape": [
"date",
{
"timeZone": "Etc/UTC"
}
]
},
{
"pattern": ".*"
}
Expand All @@ -109,5 +119,7 @@
"lastQuarter",
"lastYear",
"none"
]
],
"supportsNoneTimeframe": true,
"defaultTimeframe": "none"
}
20 changes: 16 additions & 4 deletions plugins/NinjaOne/v1/dataStreams/osPatches.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "osPatches",
"displayName": "OS Patches",
"tags": ["Security"],
"description": "OS patch compliance status including pending, failed, and installed patches",
"description": "OS patch compliance status including pending, failed, and installed patches (timeframe filters on when each record was last collected)",
"baseDataSourceName": "httpRequestUnscoped",
"config": {
"httpMethod": "get",
Expand All @@ -24,11 +24,11 @@
},
"expandInnerObjects": false,
"endpointPath": "/v2/queries/os-patches",
"pathToData": "results",
"postRequestScript": "collectionWindow.js",
"getArgs": [
{
"key": "ts",
"value": "{{timeframe.end}}"
"value": "{{typeof timeframe === 'undefined' || timeframe.enum === 'none' || timeframe.unixStart == null ? null : 'after ' + timeframe.unixStart}}"
}
],
"headers": []
Expand Down Expand Up @@ -93,6 +93,16 @@
}
]
},
{
"name": "timestamp",
"displayName": "Collection Time",
"shape": [
"date",
{
"timeZone": "Etc/UTC"
}
]
},
{
"pattern": ".*"
}
Expand All @@ -110,5 +120,7 @@
"lastQuarter",
"lastYear",
"none"
]
],
"supportsNoneTimeframe": true,
"defaultTimeframe": "none"
}
22 changes: 2 additions & 20 deletions plugins/NinjaOne/v1/dataStreams/policyOverrides.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,7 @@
"expandInnerObjects": true,
"endpointPath": "/v2/queries/policy-overrides",
"pathToData": "results",
"getArgs": [
{
"key": "ts",
"value": "{{timeframe.end}}"
}
],
"getArgs": [],
"headers": []
},
"metadata": [
Expand Down Expand Up @@ -91,18 +86,5 @@
"pattern": ".*"
}
],
"timeframes": [
"last1hour",
"last12hours",
"last24hours",
"last7days",
"last30days",
"thisMonth",
"thisQuarter",
"thisYear",
"lastMonth",
"lastQuarter",
"lastYear",
"none"
]
"timeframes": false
}
Loading
Loading