fix(chart): use numeric axes for numeric x values - #1439
Draft
lovasoa wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numericx-axis for numeric, non-time Cartesian dataxticks, horizontal bar,rangeBar, and other category-oriented behaviorxticksbehaviorThis is an interim adapter fix for SQLPage #733, using its corrected complete-series reproduction. The underlying ApexCharts behavior is tracked in ApexCharts #5086, with an open attempted upstream fix in ApexCharts PR #5259. The original report is ApexCharts #4858, including its unresolved follow-up.
SQLPage #883 and ApexCharts #5015 concern alignment when series are sparse. This PR addresses the distinct tick-formatting bug where both series are complete but ApexCharts chooses fractional tick positions and displays them as rounded integers.
Try it
windows executable
Screenshots
Both screenshots use the corrected SQL fixture at a 1280 x 720 viewport.
Before
After
Tests
npm run formatnpm testSQLPAGE_FIXTURE_BASE=http://127.0.0.1:18081 SQLPAGE_BINARY=/tmp/opencode/sqlpage-733-target/debug/sqlpage npx playwright test fixtures/chart/test.ts --project=fixtures --reporter=line(42 passed)