Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
The doc comment on the exported
UnsupportedRemoteProviderErrortype says "Currently only etcd and Consul are supported." That's stale: Viper supports five providers.What problem does it solve?:
remote.go:12definesSupportedRemoteProviders = []string{"etcd", "etcd3", "consul", "firestore", "nats"}, andAddRemoteProvider(lines 86, 100) validates against it and already documents all five. TheUnsupportedRemoteProviderErrorcomment is the only remaining place asserting the old two-provider set, so it directly contradicts the code it describes. I changed it to point atSupportedRemoteProvidersas the source of truth and list the current five, so it can't silently go stale again.Comment-only; no behavior change.
Special notes for a reviewer:
gofmt -l remote.go— cleango build ./.../go vet ./...— cleango test -count=1 ./...— all packages pass