Repository navigation
Fix spin transition-validation example and trace capture - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22.
The spin example omitted nonblocking request events, so 87 acquisition windows could not match the required single-step transition. This records the missing event and corrects the failed-CAS lock observation, removes the reference model's held-lock requirement for starting a request, and rejects incomplete or inconsistent trace input.
The default fixture now comes from a focused Asterinas/QEMU kernel test; the original windows remain byte-for-byte under
legacy/. The candidate specification is unchanged. The runner checks tool installation and separates mismatches from errors/timeouts. Batch tests retain every window, use two workers and allow ten minutes for the largest batch; individual TLC calls retain their 30-second timeout.Validation:
The new kernel fixture uses three logical actors on one CPU; it does not exercise concurrent stress or the blocking spin loop. Historical benchmark scores are not recalculated.