Repository navigation
fix(gateway): apply bounded backpressure during session replay - #264
Merged
Merged
Conversation
![kit-code-agent[bot]](https://avatars.githubusercontent.com/in/4797102?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply bounded backpressure to gateway output so session-history replay does not terminate healthy connections when retained HTTP frames temporarily fill admission capacity. Drain admitted bridge frames before driving additional HTTP work.
Technical details
Wait for retained frame ownership to end
Gateway output awaits actual frame/byte reservation release rather than relying on scheduler yields. One absolute five-second deadline covers the response, actor polls, and output from all controllers in a drain. Progress does not reset the deadline or renew leases while another controller waits; expiry terminates the connection. Queue capacities and frame-size limits are unchanged.
Pin the matching transport correction
Pin the ACP HTTP and core SDK crates to
03eab519aa5ecfc97a43bf17f9721c38c065c47bfrom danielkov/rust-sdk#4. That revision adds cancellation-safe awaitable admission and cooperative incoming SSE delivery. The core and HTTP crates share one source revision to preserve channel type identity; package versions remain unchanged.