Repository navigation
feat: product list -i, a picker over the product list - #42
Merged
Merged
Conversation
|
Claude finished @alukach's task in 16s —— View job ✅ No blocking issues — safe to merge. Reviewed Non-blocking notes:
Simplify (ponytail)
💰 Estimated review cost: $0.11 · 0m16s · 4 turns |
browse lists products in a type-to-filter picker (dialoguer's FuzzySelect), with "Load more…" while the listing has pages left. A picked product is shown as view shows it, with Back, Open in browser, Edit and Delete, which run the same code as those commands; a failed action is reported and the menu offered again. list and browse share their filters (account, -q, --tags, --featured) through a flattened Filters struct, and one page fetch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
One way to the picker: -i on list takes the same filters and refuses the printing-only flags (--json, --format, -L, --cursor). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alukach
force-pushed
the
feat/product-browse
branch
from
October 13, 2026 23:36
307d4ac to
71c3dd0
Compare
alukach
marked this pull request as ready for review
October 13, 2026 23:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
source-coop product list [ACCOUNT] [-q TEXT] [--tags …] [--featured] -iis a lightweight interactive way to click through products, without a full-screen TUI.-iis the one way in: no separate command. It refuses the printing-only flags (--json,--format,-L,--cursor), and the picker loop is plain enough to reuse if other commands get-i.ACCOUNT/PRODUCT Titlein a type-to-filter list (dialoguer'sFuzzySelect). It ends with Load more… while the listing has more pages, which fetches 50 at a time, and Quit.product viewshows it, followed by Back, Open in browser, Edit and Delete.editanddeletefunctions as the commands, so their prompts, re-asking on field errors and the typed-name delete confirmation all come for free. There's no second implementation.product list.How
listandlist -ishare one flattenedFiltersstruct (account,-q,--tags,--featured, and the URL built from them) and onefetch_pagehelper, so the flags and the paging aren't duplicated.Promptergainsfuzzy_select, which defaults toselect. Only the terminal implementation overrides it, so the scripted test prompter works unchanged.fuzzy-selectfeature.Testing
list_i_takes_filters_but_not_printing_flagschecks the flag parses with filters and clashes with the printing flags.list_i_loads_more_deletes_through_the_menu_and_quitsagainst wiremock covers load more, picking a product, deleting it through the menu (keep data: no; typed confirmation), seeing it gone with the cursor on the next product, and quitting. It checks every list and menu offered.cargo fmt,cargo clippy --all-targets -- -D warnings,cargo testandcargo test --features staging: 68 passed, on top of feat: add product commands and a gh-style api command #24's draft-saving commit (e96b301). Editing from the picker now makes feat: add product commands and a gh-style api command #24's sign-in check (GET /whoami) first.🤖 Generated with Claude Code