fix(P3): mTLS temp cleanup + shared HTTP TLS material - #8
Closed
songzhendong wants to merge 2 commits into
Closed
songzhendong wants to merge 2 commits into
songzhendong wants to merge 2 commits into
Conversation
When the HTTP CA snapshot cannot be written, fall back to the configured path without resolving symlinks so K8s secret rotation cannot invalidate session.verify. Prefer cafile whenever the CA PEM includes TRUSTED CERTIFICATE so aio cadata cannot silently drop trusted blocks from a mixed bundle.
Share one PEM material load for HTTP scheme and session/context, prefer configured CA on requests TLS fallback, drop orphaned cert temps and unused _extract_pem_blocks. CA snapshot hot-reload left intentional. Co-authored-by: Cursor <cursoragent@cursor.com>
songzhendong
changed the title
Owner
Author
|
Superseded / obsolete on this fork:
Closing to declutter. Active work remains on #7 (DNS) and #9 (CDS). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Internal fork CI for P3 polish from apache#419 review, without updating the official PR head.
mkstempfails after cert write, unlink immediately.tls_pem_material()load (no scheme/settings TOCTOU).configure_requests_sessionfallback prefers configured CA path over system trust._extract_pem_blocks.Test plan
tests/unit/test_tls.py+test_grpc_channel.pylocally (88 passed)