internal: fix aiohttp ClientSession closed after first request (fork CI only) - #10
Closed
songzhendong wants to merge 2 commits into
Closed
songzhendong wants to merge 2 commits into
songzhendong wants to merge 2 commits into
Conversation
songzhendong
force-pushed
the
fix/http-reporter-session-silent-drop
branch
2 times, most recently
from
September 19, 2026 12:54
0845fd6 to
4f2b38e
Compare
Replace async-with on the shared ClientSession (closes it after the first request) with async-with on the response. Add aclose() for session cleanup.
songzhendong
force-pushed
the
fix/http-reporter-session-silent-drop
branch
from
September 19, 2026 13:02
4f2b38e to
0cd9b15
Compare
songzhendong
changed the title
Owner
Author
|
Superseded: already on fork master via upstream apache#422 (5666826). Closing this fork PR as unused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Internal fork CI only — not for apache/skywalking-python.
Fix only:
async with self.clientpermanently closed the long-lived aiohttpClientSessionafter the first HTTP request whenSW_AGENT_ASYNCIO_ENHANCEMENT=trueandprotocol=http.async with self.client.post(...)(closes response, not session)aclose()on async HTTP clients / protocolTest plan
tests/unit/test_http_reporter.py(session reuse)