Skip to content

Add OSS Scanner build environment and threat model - #1310

Merged
korridor merged 3 commits into
mainfrom
feature/oss-scanner
Oct 9, 2026
Merged

korridor merged 3 commits into
mainfrom
feature/oss-scanner

Conversation

@korridor

@korridor korridor commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Adds the files needed to enroll solidtime in Anthropic's OSS Scanner. The scanner builds .oss-scanner/Dockerfile with network access, then audits the image offline.

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.62%. Comparing base (c994345) to head (5ab7a86).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1310   +/-   ##
=========================================
  Coverage     93.61%   93.62%           
  Complexity     2327     2327           
=========================================
  Files           321      321           
  Lines         10971    10971           
=========================================
+ Hits          10271    10272    +1     
+ Misses          700      699    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Onatcer

Onatcer commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

@korridor do you think it is worth actually running octane/frankenphp as well as the scheduler/queue in this Docker image as well or no? it would be mainly for the request-state leaks and the sync driver. if not maybe we could just add it to the threat model as this is the actual state of the docker images that we publish.

Production runs as long-lived Octane workers in FrankenPHP worker mode, so state leaking between requests
(static properties, singletons, ...) is a real risk that php artisan serve cannot reproduce. Base the scanner image
on the production FrankenPHP image, add start-octane.sh (single worker, production Caddyfile) and describe this
class of issue in the threat model.

Bundle Gotenberg (Chromium only) so the PDF export tests pass offline and PDF rendering can be exercised.
@korridor
korridor merged commit 0c58896 into main Oct 9, 2026
31 checks passed
@korridor
korridor deleted the feature/oss-scanner branch October 9, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants