Conversation
make install replaces guacd's binary and libraries while the old guacd is still running, and the end of the install restarted rustguac alone. Requires= starts a stopped guacd but never restarts a running one, so an upgrade rebuilt guacd and then went on serving the previous build until someone restarted it by hand -- which looks exactly like a guacd change that did nothing. guacd is now restarted, ahead of rustguac, whenever it is active. Nothing is cut off by it: sessions go through rustguac, which is already stopped for the upgrade or was never running. A first install still leaves both stopped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make installreplaces guacd's binary and libraries while the old guacd is still running, and the end ofinstall.shrestarted rustguac only.Requires=rustguac-guacd.servicestarts a stopped guacd but never restarts a running one, so an upgrade rebuilt guacd and then kept serving the previous build until someone ransystemctl restart rustguac-guacdby hand. From the outside that looks exactly like a guacd change that did nothing.This restarts
rustguac-guacdwhenever it is active, ahead of rustguac, and stops the install with a pointer to the journal if it does not come back. No sessions are cut off by it: they go through rustguac, which is already stopped for the upgrade or was never running. A first install still leaves both services stopped, as before, so an admin can be created first.Tested with a full
./install.sh --no-deps --no-driveover a running install on Debian 13: both units restarted (guacd a second ahead of rustguac), and the running guacd's/proc/<pid>/exepoints at the new binary rather than a deleted one.