Skip to content

Add support for Databricks + Iceberg REST - #1967

Open
Nick (stanch) wants to merge 1 commit into
mainfrom
databricks-rest
Open

Nick (stanch) wants to merge 1 commit into
mainfrom
databricks-rest

Conversation

@stanch

Copy link
Copy Markdown
Contributor

No description provided.

@claude

claude Bot commented Oct 9, 2026

Copy link
Copy Markdown

Style review

Overall the changes read well and match the surrounding content. There are a few issues to fix:

1. Missing release note
This PR adds new platform support (Iceberg REST catalog with Databricks Unity Catalog and Snowflake Horizon Catalog, plus a new Databricks integration path via Iceberg on AWS). CLAUDE.md says: "New functionality needs a release note… If a docs change documents a new feature, a behavior change, or new platform/warehouse support, add a release note in the same PR (or a follow-up PR, linked)."
Fix: add release-notes/<slug>/index.md following release-notes/_README.md, or link a follow-up PR.

2. Avoid "currently"
docs/destinations/warehouses-lakes/databricks/index.md:

³ Iceberg+Databricks combination is currently not supported for GCP pipelines.

The style guide says: "Stay in the present tense. Never use 'currently', 'now', 'in the future'…". The + shorthand also reads informally.
Fix: _³ The Iceberg and Databricks combination isn't supported for GCP pipelines._

3. Use absolute paths for new internal links
docs/destinations/warehouses-lakes/databricks/index.md:

See [Iceberg](../iceberg/index.md).
Follow the instructions for [Iceberg](../iceberg/index.md#getting-started).

CLAUDE.md says: "Use absolute paths from docs root: /docs/sources/trackers/.../index.md".
Fix: use /docs/destinations/warehouses-lakes/iceberg/index.md and /docs/destinations/warehouses-lakes/iceberg/index.md#getting-started. The neighboring Delta Lake links use the same relative pattern, so you could convert those too while you're there. The #getting-started anchor exists.

External links: the touched external URLs (https://docs.aws.amazon.com/glue/ and https://iceberg.apache.org/rest-catalog-spec/) both resolve.

Removing the duplicate default attributes from the Databricks tabs is a good fix.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
documentation c7bf402 Commit Preview URL

Branch Preview URL
Oct 09 2026, 11:38 AM

@stanch Nick (stanch) added the do not merge Flag to denote a Issue or PR which should not yet be merged (usually pending a release) label Oct 9, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Flag to denote a Issue or PR which should not yet be merged (usually pending a release)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants