Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #489
Checklist
Current behavior
No CI job checks dependencies for security advisories, yanked versions, licenses or unknown sources.
Cargo.lockis not in the repository, so a yanked version, such aschacha200.10.0, shows only on local machines.New expected behavior
The new
Dependency auditworkflow (.github/workflows/audit.yml) has two jobs:cargo deny: runscargo deny --all-features checkwith the rules indeny.toml.Apache-2.0,MITorUnicode-3.0.cargo audit: runscargo audit --deny yanked --deny unsoundon a fresh lockfile. Vulnerabilities fail the job. An unmaintained crate gives a warning only.The workflow runs on push to
main, on pull requests, every Monday, and on manual start. The weekly run finds new advisories when no one changes the code.deny.tomlhas one ignore entry:RUSTSEC-2023-0089(atomic-polyfillis unmaintained). The crate is in the tree only throughpostcard->heapless, andpostcardis a dev-dependency. It is not in the published crate.deny.tomlis added to theexcludelist inCargo.toml, so it is not in the published package.Validation
I ran these checks locally with
cargo-deny0.20.2 andcargo-audit0.22.2, on a fresh lockfile:cargo deny check:advisories ok, bans ok, licenses ok, sources ok.cargo audit --deny yanked --deny unsound: passes (one allowed warning foratomic-polyfill).chacha200.10.0 (cargo update -p chacha20 --precise 0.10.0), both tools fail the check for the yanked crate.cargo package --listdoes not includedeny.toml.Change logs
Added
Dependency auditCI workflow (cargo denyandcargo audit).deny.tomlwith the rules.Changed
deny.tomlis in theexcludelist inCargo.toml.