fix(cli): render crew tool-call activity in agent-crew chat - #126
Merged
Merged
Conversation
Line documents loopback/passthrough/background tools; crew had only the default (@function_tool, result -> LLM). Add @loopback_tool as the alias for that default so agents written to the loopback/passthrough vocabulary read naturally. Exported from smallestai.atoms.crew and .crew.tools; test asserts it aliases function_tool. Passthrough + is_background are the remaining PRO-3068 pieces and need a change on the tool-execution path (crew's tool loop is caller-driven via ToolRegistry.execute, not a framework loop), captured on the ticket.
The chat client's codec had no case for AGENT_LOG (agent.log), which the crew tool registry emits on every tool call (tool_call_start/end/error). Decoding one raised 'Unknown type agent.log', so any tool-using turn errored and dropped the reply. Register SDKAgentLogEvent and render it dimly (tool name + ok/fail), so tool activity shows in the CLI and tool turns complete.
|
crim doesn't review pull requests automatically here. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agent-crew chaterrored with "Unknown type agent.log" and dropped the reply on any tool-using turn — its codec had no case forAGENT_LOG, which the crew tool registry emits on every tool call. This registersSDKAgentLogEventin the chat client and renders it dimly (· tool start: verify_identity ✓), so tool activity is visible and tool turns complete. Verified locally against a tool-heavy crew node.