Skip to content

test(crew): premise validation harness + live integration test - #123

Merged
abhishekmishragithub merged 1 commit into
mainfrom
crew-premise-validation
Sep 24, 2026
Merged

abhishekmishragithub merged 1 commit into
mainfrom
crew-premise-validation

Conversation

@abhishekmishragithub

Copy link
Copy Markdown
Collaborator

Premise-first validation of the agent-crew core, the thing that matters most before adding features.

  • test_crew_premise_e2e.py (in-process, deterministic, fake LLM): imports, the LLM turn -> chunk stream, speak-only-when-running, failing-turn error + close, barge-in survival, background-observer silence, event-codec round-trip. 7 tests, green.
  • test_crew_integration_live.py (live, -m integration, skips without ANTHROPIC_API_KEY): a real crew node + real OpenAIClient against Anthropic streams a real turn. Verified passing live.
  • crew/CONTEXT.md: premise, domain vocabulary, seams, invariants, edge cases (read by the tdd/diagnosing-bugs skills).

No crew defects found during validation; the premise holds. mypy + ruff clean.

@crim-app

crim-app Bot commented Sep 22, 2026

Copy link
Copy Markdown

crim doesn't review pull requests automatically here.

Comment crim review on this pull request whenever you want a review.

Premise-first validation of the code-first crew core (per its new CONTEXT.md):
- test_crew_premise_e2e.py: in-process, deterministic, fake LLM. Covers the seams
  and edge cases — LLM turn -> generate_response chunks, speak-only-when-running,
  failing turn surfaces a fatal error and still closes, barge-in survival,
  background node observes silently, event-codec wire round-trip, imports resolve.
- test_crew_integration_live.py: live-gated (ANTHROPIC_API_KEY, -m integration).
  A real crew node with a real OpenAIClient against Anthropic streams a real turn.
- crew/CONTEXT.md: premise, domain vocabulary, seams, invariants, edge cases.
@abhishekmishragithub
abhishekmishragithub merged commit d84e0d2 into main Sep 24, 2026
5 checks passed
@abhishekmishragithub
abhishekmishragithub deleted the crew-premise-validation branch September 24, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant