Fix mobile video download + large-file error - #368
Merged
Merged
Conversation
- download.service: append the <a> to the DOM before click (detached clicks are ignored on mobile/Firefox) and stop revoking the blob URL after 100ms (large videos hand off to the download manager asynchronously; premature revoke aborts the save). Revoke after a long delay + on pagehide. Fixes 'processed but won't download' across all tools. - encode.lib: turn ffmpeg.wasm's cryptic NotReadableError on oversized files into a clear 'too large / out of memory — try a shorter clip or the desktop app'. - VideoCompress: warn upfront when a selected video is very large (>300MB).
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
goodwebtools | 48c4c5e | Aug 30 2026, 02:18 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
download.service: append to DOM before click + stop the 100ms premature blob-URL revoke (fixes processed-but-won't-download on mobile/large files, all tools). encode.lib: clear out-of-memory message for oversized files. VideoCompress: upfront large-file warning.