Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the correctness, routing, and security bugs that two code-review passes found in #194: multi-cloud gateway routing, the Azure Key Vault, Azure App Configuration, GCP Secret Manager and GCP Pub/Sub providers, and the workload runtime.
Related Issue
Refs #194
Changes
Gateway routing (
internal/gateway/protocol.go)azureVaultServiceroutes*.vault.azure.netand*.azconfig.iohosts directly. A bare/secrets,/keysor/kvpath routes to Azure only if the request also hasapi-version. Before this, S3 buckets and Azure blob containers whose names started with those prefixes were hijacked.messages-*no longer goes to Queue.secrets-*no longer goes to Secret Manager.Workload / Lambda
oci.go: docker is the first auto-detected runtime again. Error messages name only the subcommand, so--env K=Vsecrets no longer leak into 503 bodies./, so/2015-03-31/functionsXno longer matches.GCP Secret Manager
GetSecretVersionhandler.GetSecretVersion,AddSecretVersionandListSecretVersions, which fixes a data race with destroy.latestnow means the newest version created, matching GCP.secretIdis validated against^[A-Za-z0-9_-]{1,255}$.GCP Pub/Sub
CreateSubscriptionreturns 404 if the topic does not exist.Azure Key Vault
SetSecretwith no value returns 400.null.ListResourcesnow lists every vault.Azure App Configuration
label=%00matches unlabeled keys.ListResourcesnow lists every store.Docs
docs/configuration.md: the YAML example no longer sets both the top-levelservicesblock andproviders.aws.services. With both set, sqs and dynamodb did not start.Test Plan
latestsemantics, andsecretIdvalidation.Known issues before merge
SetSecret400 likely breaks the Azure SDK. The SDK sends a bodyless probe first, and the emulator never answers with a 401WWW-Authenticatechallenge. Either revert to accepting an empty body or add the challenge and update the compat tests.GetSecretVersioncase needsmake codegenand updated figures indocs/coverage.md.Checklist
golangci-lint run)changie new, one sentence and two at most, see RELEASE.md) — or N/A (docs/tests/chore only)