Repository navigation
Update/fe pattern updates - #127
Merged
Merged
Conversation
…leanup to start in a better place for custom themes
| h5, .h5{ font-size: ~'clamp(@{font-size-h5-m}, 1rem + 0.5vw, @{font-size-h5})'; } | ||
| h6, .h6{ font-size: ~'clamp(@{font-size-h6-m}, 0.875rem + 0.5vw, @{font-size-h6})'; } | ||
| //max fontsize value at 1100px, min fontsize value at 700px | ||
| h1, .h1{ font-size: ~'clamp(@{font-size-h1-m}, 0.781rem + 2.5vw, @{font-size-h1})'; } //clamp(1.875rem, 0.781rem + 2.5vw, 2.5rem) |
Contributor
There was a problem hiding this comment.
Do you want to have a comment with the link to minmax actual numbers?
| {% set imageHeight = attribute(imageSizes, crop).height %} | ||
|
|
||
| <img loading="lazy"{{ class ? ' class="' ~ class ~ '"' }} src="{{ image.src(crop) }}" {{ generate_retina_srcset(image.src(crop), 2) }} alt="{{ image.alt() }}" width="{{ imageWidth }}px" height="{{ imageHeight }}px" /> | ||
| <img loading="lazy"{{ class ? ' class="' ~ class ~ '"' }} src="{{ image.src(crop) }}" {{ generate_retina_srcset(image.src(crop), 2) }} alt="{{ customAlt|default(image.alt()) }}" width="{{ imageWidth }}" height="{{ imageHeight }}" /> |
Contributor
There was a problem hiding this comment.
Do we need the px? If not we need to update sprig too?
digitalNightingale
approved these changes
Sep 15, 2026
digitalNightingale
left a comment
digitalNightingale
left a comment
Contributor
There was a problem hiding this comment.
I added two comments with questions, but approving the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All updates focus on the base front end setup for templates and patterns. Focus was on html and css with a little bit of added js functionality for news filtering.