Repository navigation
Update/disabling tags - #122
Open
amerk-sitecrafting wants to merge 2 commits into
Open
amerk-sitecrafting wants to merge 2 commits into
amerk-sitecrafting wants to merge 2 commits into
Conversation
Contributor
|
I didn't run a test but the code looks good to me, like you said on this side of things its pretty simple. I would say that we want the change in conifer to be merged first then this PR would include the update for conifer so its not required to change the target conifer install. |
rbhensley
approved these changes
Sep 16, 2026
rhendrickson-sc
approved these changes
Sep 16, 2026
rhendrickson-sc
left a comment
rhendrickson-sc
left a comment
There was a problem hiding this comment.
Same as Reena, I didn't run any tests or clone the repo, but the updates themselves look good! I'll defer to Reena's suggestions, since I feel like this affects her more day-to-day than it affects me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extremely simple update utilizes the new
disable_tagsfunction from Conifer!Note, in order to test this you will need to target the dev branch. To do so, you can replace
"sitecrafting/conifer": "^1.0"withdev-update/removing-tagsand run acomposer update. This will install the update branch which contains thedisable_tagsfunction.