Repository navigation
Update/ajax logging - #172
Merged
Merged
Conversation
rhendrickson-sc
approved these changes
Oct 1, 2026
rhendrickson-sc
left a comment
rhendrickson-sc
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Thank you for your patience with this.
I left 2 comments but they're just questions, no need to change anything before merging.
| * Remove dependencies that were no longer needed. | ||
| * Migrate from [Gitbook](https://www.gitbook.com) to [VitePress](https://vitepress.dev). | ||
|
|
||
| ## v1.0.5 |
Contributor
There was a problem hiding this comment.
Totally optional, but I've noticed that most projects will put their most recent changes at the top of the change-log instead of at the bottom. Not sure if that's something you'd want to do, or if this approach follows an existing convention we do.
| $this->action = $request['action']; | ||
| $this->request = $request; | ||
| $this->action_methods = []; | ||
| static::$logger = $logger; |
Contributor
There was a problem hiding this comment.
Just a question: why do the other parameters follow $this-> but the logger is doing static::?
Deploying conifer-plugin with
|
| Latest commit: |
9b61df9
|
| Status: | ⚡️ Build in progress... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: # 248
Issue
The AbstractBase does not support logging for Ajax requests
Solution
Now it does!
I've also updated the docs and changelog.
Impact
None, all existing code should continue to work as is. The only change to source code includes optional arguments
Usage Changes
Add a not-quite-the-same static log() function to AbstractBase.
Considerations
While logging in the AjaxHandler is neat, we could explore a more generic, global solution for logging that could be used in PHP, Twig, and does not require much setup on the developer's part.
Testing
I've included updated unit tests for the new logging functionality. PHPStan came back clean, and all tests pass.