fix: release v0.6.4 with original source line numbers - #18
Merged
Merged
Conversation
Map formatted display lines to original input coordinates and use them in gutters, title ranges, raw records, tool hints, and numeric navigation. Keep JSONL jumps bounded and cancellable, with honest unknown coordinates in tail-first views and source-aware numbering across append and rotation. Align the Cargo workspace, core dependency, lockfile, and npm wrapper at 0.6.4. Document the buffered source-alignment cost and follow-mode behavior, and add mapping, navigation, timeline, and real-terminal verification.
Remove a redundant test import rejected by the current stable compiler in CI. Add an explicit repository-variable opt-out for npm so the authorized GitHub and crates.io release can proceed while npm credentials are renewed, and document the channel availability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release
fmtviewandfmtview-coreas 0.6.4 on crates.io and GitHub Releases, with all workspace/npm metadata aligned to 0.6.4. File-viewer line numbers and numeric jumps now refer to the original input, so a JSONL record remains source line 2 even when the preceding record expands into many display lines. Expanded rows use continuation markers; raw views, title ranges, and tool-pair hints share the source coordinates.Lazy source jumps run in cancellable batches. Tail-first timelines show
?until their prefix is known, preserving bounded startup, and track original coordinates across appends and rotation. Whole-document JSON/XML/HTML viewing adds a buffered source-alignment pass and numeric map; formatted text remains on disk. README and release notes document these tradeoffs.Validation:
cargo fmt --check, 409 passing tests,cargo clippy --all-targets -- -D warnings, locked release and static musl builds,cargo publish -p fmtview-core --dry-run --locked, and a Kitty/Xvfb recording of the static release binary. Inspected keyframes confirm source jumps to 2 and 100, raw/structured toggling, scroll, wrap toggle, and clean quit.A release-mode comparison pinned to the same CPU, with a warm-up pair and nine alternating AB/BA samples, measured viewport rendering at 20.84 -> 20.91 ms, lazy preload at 10.24 -> 10.93 ms, and unchanged terminal draw bytes (133,048). Source alignment increased the whole-document JSON/XML benchmarks from 59.13 -> 82.88 ms and 79.41 -> 99.13 ms respectively. These are benchmark-batch medians on a shared host, not a universal no-regression claim.
Npm publication is explicitly paused at the maintainer's request while credentials return 401. The release workflow supports
NPM_PUBLISH_ENABLED=falseto skip that job independently; release documentation and notes describe the pause and resumption. Also remove a redundant test import rejected by current stable Clippy in CI.