Repository navigation
docs: trim comments in the CI-auth workflows - #65
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (5)
Note Some coding-guideline sources were skipped; the reason is listed next to each one. Other guidelines were applied as usual. On a public repository, sources from your configuration are listed without their names. Skipped guideline sources (1)✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
michieldegezelle
commented
Oct 6, 2026
Comment-only: each file is byte-identical with comments stripped. Keeps the "why it's like this" and the caller contract; drops review narrative, measurement history and rejected-alternative essays (those live in commit history and the review learnings). Also fixes a few comments that had gone stale (cron references, "only called by be_market"). - run_tests_inline_auth.yml: 356 -> 142 comment lines - repair_firm_auth.yml: 105 -> 45 - push_to_review_firm.yml: 66 -> 21 - refresh-config-json/action.yml: 50 -> 17 - update_templates_production.yml: delete an 86-line commented-out job Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
michieldegezelle
force-pushed
the
trim-workflow-comments
branch
from
October 6, 2026 07:55
1b675d8 to
185459a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Comment-only clean-up of the shared CI-auth workflows, so the workflow structure is readable at a glance. Each file is byte-identical with comments stripped, so no behaviour changes for any caller.
What stays: the caller contract in each header, and short "why it's like this" notes (at most ~3 lines per job or step). What goes: review narrative, measurement history and essays about rejected alternatives. Those live in the commit history and the review learnings. A few comments that had gone stale are fixed along the way (cron references, "only called by be_market").
run_tests_inline_auth.ymlrepair_firm_auth.ymlpush_to_review_firm.ymlrefresh-config-json/action.ymlupdate_templates_production.yml: deletes an 86-line commented-out job at the end of the file.Not touched:
run_tests.ymlandcheck_auth.yml(go once every market has switched),run_sampler.yml(next step).Type of change
Checklist
Test plan
mainwith comment lines stripped: identicalactionlint: no new findings (the shellcheck notices predate this change)🤖 Generated with Claude Code