Skip to content

Reject authoring a change whose type isn't registered - #146

Open
myieye wants to merge 1 commit into
claude/model-versions-register-change-typesfrom
claude/reject-unregistered-change-types
Open

myieye wants to merge 1 commit into
claude/model-versions-register-change-typesfrom
claude/reject-unregistered-change-types

Conversation

@myieye

@myieye myieye commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

[Claude, autonomous]

AddChange with an unregistered change type used to store it without $type, so every later read threw; DataModel.ToChangeEntity now throws an ArgumentException instead. Stacked on #145.

🤖 Generated with Claude Code

@myieye
myieye added this pull request to stack #147 October 20, 2026 11:02
@myieye myieye changed the title claude/reject unregistered change types [claude] Reject authoring a change whose type isn't registered Oct 20, 2026
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 47 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: aa54cb25-8b89-4997-b16d-0b018909dcfe
📥 Commits

Reviewing files that changed from the base of the PR and between 575e1a9 and a2a82ff.

📒 Files selected for processing: 4
  • src/SIL.Harmony.Tests/ModelVersionTests.cs
  • src/SIL.Harmony/Changes/PeekThenConcreteChangeConverter.cs
  • src/SIL.Harmony/Config/HarmonyConfig.cs
  • src/SIL.Harmony/DataModel.cs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@myieye
myieye force-pushed the claude/reject-unregistered-change-types branch from 5a3fe41 to 4879ac5 Compare October 20, 2026 11:42
@myieye
myieye force-pushed the claude/reject-unregistered-change-types branch from 4879ac5 to b6041f7 Compare October 20, 2026 12:38
@myieye
myieye force-pushed the claude/reject-unregistered-change-types branch from b6041f7 to 8002872 Compare October 20, 2026 12:47
@myieye myieye changed the title [claude] Reject authoring a change whose type isn't registered Reject authoring a change whose type isn't registered Oct 20, 2026
@myieye
myieye requested a review from hahn-kev October 20, 2026 12:58
@myieye
myieye marked this pull request as ready for review October 20, 2026 12:58
An unregistered change was stored without $type and every later read threw.
DataModel.ToChangeEntity now throws an ArgumentException in AddChange instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@myieye
myieye force-pushed the claude/reject-unregistered-change-types branch from 8002872 to a2a82ff Compare October 20, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants