Skip to content

fix: keep astro check out of dist after a local build - #735

Merged
eseidel merged 1 commit into
mainfrom
fix/astro-check-skip-dist
Oct 17, 2026
Merged

eseidel merged 1 commit into
mainfrom
fix/astro-check-skip-dist

Conversation

@eseidel

@eseidel eseidel commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

A second npm run build in the same checkout fails: astro check type-checks the bundled JavaScript in dist/ left by the first build and aborts. CI never sees it because it builds from a clean checkout, so it only bites locally, and the workaround is deleting dist/ before every build.

The cause is tsconfig.json's exclude. Astro's base tsconfig excludes dist, but setting exclude here replaces that list instead of adding to it, so dist was no longer excluded once functions was. This puts dist back next to functions.

Checked by building with a stale dist/ present: astro check reports 0 errors and the build completes.

@eseidel

eseidel commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

lgtm

@eseidel
eseidel enabled auto-merge (squash) October 16, 2026 20:09
@eseidel
eseidel merged commit 3dfce14 into main Oct 17, 2026
4 checks passed
@eseidel
eseidel deleted the fix/astro-check-skip-dist branch October 17, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant