Conversation
- タイムアウト時に label と受信済み event_type 一覧を AssertionError に含める - `test_signaling_notify.py` の全呼び出しに明示タイムアウトと label を指定する - タイムアウト動作の単体テストを追加する
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
tests/test_signaling_notify.pyでwait_notifyのタイムアウトがデフォルト 5 秒に張り付いて flake する問題を修正する。タイムアウトをテスト側で明示し、タイムアウト時に受信済み notify の内訳が分かる assert メッセージにする。変更内容
tests/client.pyのSoraClient.wait_notifyにlabelパラメータを追加し、タイムアウト時に label・timeout・受信済みのevent_type一覧を含むAssertionErrorを raise するように変更timeoutの型をfloatに変更(デフォルトは従来どおり 5 秒)tests/test_signaling_notify.pyの全 4 箇所に明示的なタイムアウト(connection.created= 10 秒、connection.destroyed= 15 秒)と日本語の label を指定tests/test_wait_notify.pyを新規追加し、タイムアウト時のエラーメッセージ(label・timeout・受信済みevent_type一覧・空一覧)を検証完了条件
tests/test_signaling_notify.pyのwait_notify呼び出しすべてに明示的なタイムアウトと用途が分かる label が付くことwait_notifyがタイムアウトしたとき、label と、それまでに受信したevent_typeのリストが assert メッセージに含まれること関連 issue