Skip to content

Migrate to feature/s3/transfermanager - #471

Merged
taoki-ss merged 7 commits into
masterfrom
migrate-to-transfermanager
Oct 16, 2026
Merged

taoki-ss merged 7 commits into
masterfrom
migrate-to-transfermanager

Conversation

@taoki-ss

Copy link
Copy Markdown
Contributor

feature/s3/manager is deprecated in favor of feature/s3/transfermanager.

As the argument types of WithUploaderOptions() and WithDownloaderOptions() are changed, bump the major version to v3.
Go 1.23 is dropped since transfermanager requires Go 1.24.
Also add migration guide.

@taoki-ss taoki-ss self-assigned this Oct 14, 2026
@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.92%. Comparing base (4df4d36) to head (fa682e4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #471      +/-   ##
==========================================
+ Coverage   81.88%   81.92%   +0.04%     
==========================================
  Files           5        5              
  Lines         414      415       +1     
==========================================
+ Hits          339      340       +1     
  Misses         45       45              
  Partials       30       30              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@taoki-ss
taoki-ss requested a review from at-wat October 14, 2026 09:28
Comment thread MIGRATION.md Outdated
@taoki-ss
taoki-ss requested a review from at-wat October 15, 2026 04:26

@at-wat at-wat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taoki-ss

Copy link
Copy Markdown
Contributor Author

@at-wat Thank you for your review and approval.
Before merging, I would like to confirm two points regarding the release.

  1. Would it be acceptable for me to merge this PR and tag v3.0.0 (including creating the GitHub Release)?
  2. Would it be acceptable to release v3.0.0 directly, without release candidates?

@at-wat

at-wat commented Oct 16, 2026

Copy link
Copy Markdown
Member

@taoki-ss

  • Would it be acceptable for me to merge this PR and tag v3.0.0 (including creating the GitHub Release)?

Yes, please tidy up the commit message on squash merge.

  • Would it be acceptable to release v3.0.0 directly, without release candidates?

Creating v3.0.0 directly would be fine if there are no other pending breaking changes and the current changes are confident enough.

@at-wat

at-wat commented Oct 16, 2026

Copy link
Copy Markdown
Member

BTW, it's better to merge the pending dependency updates before creating the new release

@taoki-ss
taoki-ss merged commit 8e7f9b6 into master Oct 16, 2026
4 checks passed
@taoki-ss
taoki-ss deleted the migrate-to-transfermanager branch October 16, 2026 04:55
@taoki-ss

Copy link
Copy Markdown
Contributor Author

@at-wat Thank you for the confirmation.
I have merged the pending dependency updates (#468 and #469) before this PR, and released v3.0.0.
https://github.com/seqsense/s3sync/releases/tag/v3.0.0

The AWS SDK updates (#453, #458, #460 and #470) were already included in this PR and were closed automatically by Renovate, and #466 was superseded by #469.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants