refactor(queue): separate todo2code verify command - #156
Conversation
There was a problem hiding this comment.
Deterministic Validator approval for exact head 6d48a2736be7703f9f39eda98f84f966c30c9974.
Ticket: ticket-120
Correlation ID: local-semcod-koru-pr-156-ticket-120
Model: zai/glm-5.3
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). Behavior-preserving extraction of the todo2code verify command construction into _todo2code_verify_command(). The refactored call site retains the gating on empty verify_command, diagnostic ID regex validation, and t2c_executable fail-closed behavior. New project/ticket-120 metadata files are consistent with the allowedPaths budget.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Actual PR impact radar
Exact range: 1d9f14e3678dd30d5e6178b7571ad99ee891b1d5...6d48a2736be7703f9f39eda98f84f966c30c9974
Change digest: 7a612696acc9918ffddeb55dbfec92752336a6915711ef8921045e4fd3b8612b
Score: 32/100 (M), estimated 36 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":73,"base_sha":"1d9f14e3678dd30d5e6178b7571ad99ee891b1d5","binary_files":0,"categories":{"code":1,"configuration":1,"docs":1},"change_digest":"7a612696acc9918ffddeb55dbfec92752336a6915711ef8921045e4fd3b8612b","comparison":"1d9f14e3678dd30d5e6178b7571ad99ee891b1d5...6d48a2736be7703f9f39eda98f84f966c30c9974","deletions":21,"file_count":3,"files":["project/ticket-120/README.md","project/ticket-120/intent.json","src/koru/queue/ticket_templates.py"],"head_sha":"6d48a2736be7703f9f39eda98f84f966c30c9974","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":2,"delivery":1,"scope":1,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":36,"within_budget":false},"impact":{"components":["project","src/koru"],"files":["project/ticket-120/README.md","project/ticket-120/intent.json","src/koru/queue/ticket_templates.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":32,"split":{"parts":[{"estimated_minutes":13,"name":"Implement project","scope":["project"]},{"estimated_minutes":13,"name":"Implement src/koru","scope":["src/koru"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-120"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-120: refactor(queue): separate todo2code verify command</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,55 80,59 79,85 59,71 56,61" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 36m</text></svg>DECISION D-120-2116
TICKET ticket-120
HEAD_SHA 6d48a2736be7703f9f39eda98f84f966c30c9974
CORRELATION_ID local-semcod-koru-pr-156-ticket-120
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["standard packs / conformance=PASS","governance / enforce=PASS","governance / remote lifecycle=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","standard packs / conformance"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT superseded_checks = ["smoke"]
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"1d9f14e3678dd30d5e6178b7571ad99ee891b1d5","head_sha":"6d48a2736be7703f9f39eda98f84f966c30c9974","change_digest":"7a612696acc9918ffddeb55dbfec92752336a6915711ef8921045e4fd3b8612b","score":32,"complexity":"M","estimated_minutes":36,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Extracts todo2code diagnostic verification command construction while preserving contract gating, validated diagnostic IDs, source binding, defaults and labels.\n\nValidation: 7 focused tests, Koru-driven regressions, Ruff, governance, Docker Compose and compileall passed. Ticket: ticket-120.