Skip to content

fix: set explicit RHTAS service URLs in gitsign e2e test - #104

Merged
jkopriva merged 1 commit into
release-1.4from
backport-gitsign-service-urls-1.4
Oct 12, 2026
Merged

jkopriva merged 1 commit into
release-1.4from
backport-gitsign-service-urls-1.4

Conversation

@jkopriva

@jkopriva jkopriva commented Oct 9, 2026

Copy link
Copy Markdown

Backport from main #71

Assisted-by: Codex

Backport from main #71

Assisted-by: Codex
@qodo-for-securesign

Copy link
Copy Markdown

PR Summary by Qodo

Configure RHTAS service URLs explicitly in the Gitsign e2e test

🐞 Bug fix 🧪 Tests 🕐 Less than 10 minutes

Grey Divider

AI Description

• Require a Fulcio URL before running the Gitsign end-to-end test.
• Configure Gitsign to use the test environment’s Fulcio, Rekor, and OIDC services instead of
 defaults.
Diagram

graph TD
  A["API service URLs"] --> B["Prerequisite check"] --> C["Repository config"] --> D["Gitsign"]
  D --> E["Fulcio"]
  D --> F["Rekor"]
  D --> G["OIDC issuer"]
Loading
High-Level Assessment

Keep the explicit per-repository configuration. It matches the existing Gitsign setup in another end-to-end test and avoids relying on service defaults or changing global Git configuration.

Files changed (1) +4 / -1

Bug fix (1) +4 / -1
gitsign_sign_verify_test.goPin Gitsign to configured RHTAS endpoints +4/-1

Pin Gitsign to configured RHTAS endpoints

• Adds Fulcio to the test’s mandatory API configuration checks. Sets the local repository’s Gitsign Fulcio, Rekor, and issuer options from the corresponding API values before signing commits.

test/gitsign/gitsign_sign_verify_test.go

@qodo-for-securesign

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@jkopriva
jkopriva merged commit 2e01ddc into release-1.4 Oct 12, 2026
6 checks passed
@jkopriva
jkopriva deleted the backport-gitsign-service-urls-1.4 branch October 12, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants