integrate existing i18n resources for contentDescriptions and toast messages - #697
Merged
Conversation
Collaborator
Author
|
not sure if this PR requires a changelog entry, please let me know @andrewtavis ! |
andrewtavis
added
the
no-changelog
andrewtavis
approved these changes
Sep 10, 2026
andrewtavis
left a comment
andrewtavis
left a comment
Member
There was a problem hiding this comment.
praise: All looks great here, @ashb155! Thanks for your continued work on i18n and a11y for the project!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR integrates existing
i18nstring resources across contentDescriptions and Toast messages where hardcoded strings were being used instead of referencing.Related issue