chore: release main - #506
Open
stainless-app[bot] wants to merge 3 commits into
Open
Conversation
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
|
|
||
| # A git object name: 40 hex for SHA-1, 64 for SHA-256, or an abbreviation down to | ||
| # git's own 7-character minimum. | ||
| _GIT_SHA_RE = re.compile(r"[0-9a-fA-F]{7,64}") |
There was a problem hiding this comment.
If an opted-in deployment supplies a 41–63-character hexadecimal value, this regex accepts it even though it cannot be a SHA-1 or SHA-256 object name, causing SGP to store misleading __commit_sha__ metadata that cannot identify a real commit.
Suggested change
| _GIT_SHA_RE = re.compile(r"[0-9a-fA-F]{7,64}") | |
| _GIT_SHA_RE = re.compile(r"(?:[0-9a-fA-F]{7,40}|[0-9a-fA-F]{64})") |
Knowledge Base Used: Tracing pipeline
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/agentex/lib/core/tracing/code_revision.py
Line: 32
Comment:
**Reject invalid commit lengths**
If an opted-in deployment supplies a 41–63-character hexadecimal value, this regex accepts it even though it cannot be a SHA-1 or SHA-256 object name, causing SGP to store misleading `__commit_sha__` metadata that cannot identify a real commit.
```suggestion
_GIT_SHA_RE = re.compile(r"(?:[0-9a-fA-F]{7,40}|[0-9a-fA-F]{64})")
```
**Knowledge Base Used:** [Tracing pipeline](https://app.greptile.com/scale-ai/-/custom-context/knowledge-base/scaleapi/scale-agentex-python/-/docs/tracing-pipeline.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Stainless prepared a new release
agentex-client: 0.26.0
0.26.0 (2026-08-31)
Full Changelog: agentex-client-v0.25.0...agentex-client-v0.26.0
Features
agentex-sdk: 0.26.0
0.26.0 (2026-08-31)
Full Changelog: agentex-sdk-v0.25.0...agentex-sdk-v0.26.0
Chores
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions
Greptile Summary
The PR releases agentex-client and agentex-sdk 0.26.0 and adds opt-in source-revision metadata to SGP spans.
__commit_sha__, avoiding mutation of shared span data.Confidence Score: 4/5
The PR appears safe to merge after addressing the non-blocking commit-length validation and test-formatting issues.
The feature preserves existing span metadata and remains opt-in, but the validator can label invalid-length hexadecimal values as commits, and several new test lines violate repository formatting standards.
Files Needing Attention: src/agentex/lib/core/tracing/code_revision.py; tests/lib/core/tracing/processors/test_sgp_tracing_processor.py
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR App[Agent calls code_revision.enable] --> Resolve[Resolve explicit SHA or environment] Resolve --> Validate[Validate SHA-shaped value] Validate --> Registry[Process-wide commit revision] Span[AgentEx span] --> Processor[SGP tracing processor] Registry --> Processor Processor --> Copy[Copy dictionary metadata] Copy --> Stamp[Add __commit_sha__] Stamp --> SGP[SGP tracing backend]Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "chore: release main" | Re-trigger Greptile
Context used: