ci: add contributor guidelines, agent skills and commit message checks - #37
Draft
erkamyaman wants to merge 2 commits into
Draft
erkamyaman wants to merge 2 commits into
erkamyaman wants to merge 2 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
erkamyaman
force-pushed
the
ci/contributor-guidelines
branch
3 times, most recently
from
September 28, 2026 16:14
42e0235 to
fb40407
Compare
…efreshed UI The devtools ran as a single panel with data mostly from source scans, and every inspector looked a little different. Move them into @devframes/hub with a dock per tool (Angular, NgRx, Analog, plus NativeScript and Capacitor as coming soon), give every inspector live data from the running app, and restyle the whole panel around one theme. - Hub: one shared frame follows the rail, the amber launcher opens the whole hub, WebSocket transport, and hub connections stay local - Components: live tree, one row per instance, with inputs, outputs, listeners and injected services - Injectors: real injectors only, the environment chain, the lookup path, and which injector supplied each dependency - Signals: component picker, linkedSignal values, history kept across components - NgRx: @ngrx/signals and classic stores found through the environment injectors, with a change log, diffs and restore - Forms, Router, SSR & HTTP, Analog, Pipes, Dashboard: stable ids, per-tab data with expiry, correct counts, fewer false findings, lighter pushes - UI: SCSS theme with a one-line accent change, shared mixins, a custom accessible dropdown, consistent toolbars and states; axe clean in dark and light - Demo: rebuilt as Angular Travel with destinations, a signal store, resolvers and guards, a Signal Forms booking flow and a restyled DevTools Lab
Contributors and AI agents had no shared rules for commits, code or UI, so every change drifted a little from the last one. Add guides for the commit format, coding standards, UI and fixup commits, skills and roles that carry the same rules for agents, git hooks that format staged files and check commit messages, a CI workflow that validates the pull request title and every commit, a skills check, and pull request and issue templates.
erkamyaman
force-pushed
the
ci/contributor-guidelines
branch
from
September 28, 2026 16:19
fb40407 to
cfc37e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #36; the diff shrinks to the files below once #36 is merged.
What and why
Contributors and AI agents had no shared rules for commits, code or UI. This adds them, and the checks that keep them.
docs/contributing/: commit message format with this repo's scopes, coding standards (including how inspectors read the running app), UI guidelines (theme tokens, one-line brand change, page anatomy, accessibility), and fixup commits..claude/skills/:devtools-ui,devtools-inspector,devtools-verify,devtools-commit..claude/agents/:ui-engineer,inspector-engineer,a11y-reviewer,devtools-reviewer..githooks/, turned on bypnpm install:pre-commitformats staged files,commit-msgwarns when a message doesn't follow the format..gitmessageis set as the commit template.Commit messageworkflow checks the PR title and every commit;ci.ymlrunspnpm skills:check.pnpm commit:check(commits on your branch) andpnpm skills:check(skills and roles frontmatter, links and paths)..gitattributesmarksextension/uiand the lockfile as generated.How it was verified
pnpm format:check,pnpm skills:check(8 skills and roles),pnpm commit:checkon this branch's commitcommit-msghook warns without blockingNotes for reviewers
docs. Older commits in open pull requests will fail the new check until they are reworded or squashed.Commit messagea required check needs a branch protection change.