Skip to content

docs: record #392 packaged Bot lock acceptance - #518

Merged
sambitcreate merged 2 commits into
mainfrom
feature/issue-392-packaged-acceptance-audit
Oct 17, 2026
Merged

sambitcreate merged 2 commits into
mainfrom
feature/issue-392-packaged-acceptance-audit

Conversation

@sambitcreate

@sambitcreate sambitcreate commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

Summary

Evidence

The package was built from 8586738e, whose Git tree matches merged main 6c2b44bb. The packaged app held the profile guard against an upgraded Bot host. After killing the packaged owner, three ready claimants yielded exactly one winner; a later packaged launch acquired the profile after an upgraded host exited. All test launches used generated temporary profiles, which were removed after the runs. This is a signed development package, not a notarized release or physical-device test.

Verification

  • npm run test:ci-policy on Node 22.22.3: 63/63 passed.
  • git diff --check origin/main...HEAD: passed.
  • Audit includes npm run package, npm run package:verify, codesign --verify, and runtime outcomes from the isolated acceptance run.

Documentation only. Please review this record before closing #392; do not merge it as part of this task.

Exact-head gates after #500 main merge

  • Head a62b8ac6df5c6759d051abf5383734d20453d67e merges main 47b7a50398b661992a77ad0329171baf11fc73a6 without rebase or force-push. The current PR diff remains the same two documentation files.
  • Exact-head CI run 38985520912 completed successfully; CI required, Linux x64, and Linux arm64 passed. Fedora RPM was skipped by the changed-area policy. Local Node 22 CI-policy suite passed 63/63, and git diff --check passed.
  • Pullfrog exact-head check succeeded. It found no new substantive review needed because the merge left both documentation files unchanged; its earlier review had no findings.
  • Hermes full exact-head review completed with confidence 5/5 and no findings. No review threads remain unresolved.

This PR is awaiting the coordinator's SHA-matched merge; no auto-merge is configured.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — Reviewed both documentation changes against issue #392, the merged source, and commit tree identities.

  • Packaged acceptance record: Documents signed macOS development-package verification, isolated Bot profile contention, three-claimant recovery after SIGKILL, reverse contention, and validation limits.
  • Project memory: Records the #499 merge and links the packaged acceptance audit.

The tested and merged commit trees match, and the documented commands and runtime markers agree with the source. The macOS acceptance run was not repeated in this Linux review environment.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@very-hermes-bot

very-hermes-bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Collaborator

Hermes Review Bot

Confidence: 5

Engine: agy/gemini-3.8-flash-high
Review mode: full
Head: a62b8ac6df5c6759d051abf5383734d20453d67e
Generated: 2026-10-17T00:18:58+00:00
Reviews: 1

Summary

Records the signed macOS development package acceptance audit for issue #392, documenting native flock guard contention and SIGKILL recovery for Bot profiles following the PR #499 merge. The audit details both contention directions (packaged owner vs. source host contender, and source host owner vs. packaged contender), three-claimant race behavior upon owner death, and validation limits (development package vs. notarized release). Maintainers should double-check that the recorded acceptance parameters and limits satisfy the closing criteria for issue #392 before closing the issue.

Confidence Score: 5/5

Full local verification confirmed the tested commit (8586738e) and merged main (6c2b44bb) share the exact tree hash (aa239c39ecc60a2b338b0d1b026c33efd9eba781), and all referenced paths, scripts, helper binaries, and harness flags match the repository contracts.

📁 Important Files Changed
  • .memory/lease-reclaim-fencing.md: Records the PR Fence CLI and Bot stale lease recovery #499 merge SHA (6c2b44bb), verified parity with head 8586738e, acceptance summary, and pointer to the detailed audit document.
  • docs/testing/issue-392-packaged-bot-profile-lock-acceptance.md: Added test record documenting package build/verify commands, code signing validation, process contention/kill harness scenarios, and explicit test environment limits.

Findings

No findings.

Sequence Diagram

Unchanged or not applicable for this change.

[]

Last reviewed commit: a62b8ac6df5c
Reviews (1) · Comment /hermes review to trigger a new review · /hermes review full for full re-review

@sambitcreate
sambitcreate merged commit 3473089 into main Oct 17, 2026
22 checks passed
@sambitcreate
sambitcreate deleted the feature/issue-392-packaged-acceptance-audit branch October 17, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants