Repository navigation
feat: private reckoning overlay and Reckoning workbook sheet - #277
Merged
Merged
Conversation
…ders; skip truth check on dry runs
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35338dfc9c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional, private reckoning overlay: a YAML file of per-family verdicts (fate + tags) read at run time via
--reckoning-overlay PATHorGHRA_RECKONING_OVERLAY, and shown in a visible Reckoning workbook sheet.reckoning_overlay.py: strict loader and validator (duplicate keys, cross-family duplicate members with normalized, case-folded paths, assimilate targets, timestamps). Fails loudly in CLI preflight, before the GitHub audit runs.Matched projects,Unmatched members, and an "Unreckoned projects" block so gaps are visible._archive/is treated as a discovery container with archived catalog defaults; live checkouts always outrank archived clones, and observed checkouts outrank external-worktree placeholders.output/, truth, HTML or Notion; a packaging test builds the sdist and wheel and scans packaged files for verdict content.No behavior change without an overlay
With no flag and no env var, the workbook sheet set, truth, CLI and nightly behave exactly as before (workbook gate checks this in both modes).
Verification
make test: 3764 passed, 2 skipped.make lint: clean. Type-check: no new diagnostics over the pre-existing baseline.make workbook-gatepasses with and without--synthetic-reckoning-overlay.