Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: baed8f092b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if "plan_generated_at" in transition: | ||
| _parse_datetime( | ||
| transition["plan_generated_at"], | ||
| field_name="cohort.transition.plan_generated_at", |
There was a problem hiding this comment.
When the collector is given an old but otherwise valid plan, this check accepts its timestamp without bounding it against the newly produced receipt. The receipt can therefore be fresh while publication rewinds all recency derivation to an arbitrarily old instant, allowing a repository that is stale today to remain classified as recent and omitted from the current security cohort. Reject future timestamps and plans older than the permitted collection interval, or bind the plan age to produced_at, before this value can drive canonical PortfolioTruth.
AGENTS.md reference: src/AGENTS.md:L5-L10
Useful? React with 👍 / 👎.
|
Superseded by #274, which fixes the same clock race (and adds pending-coverage reporting and R3 diagnostics). Closing as a duplicate. |
1 participant
portfolio-maintenance failed on 2026-10-11 at 2 AM PT: the 01:30 cohort plan and the 02:00 R3 recomputation derived attention at different instants, and a repo crossed the 30-day recent/stale cliff in between. The collector now records the plan's generated_at in the receipt transition; publication derives candidate (R3) and final (R5) attention at that instant. Freshness, observation times and snapshot generated_at stay on the publication clock; older receipts keep wall-clock derivation; exact set equality still rejects real membership changes. Checks: ruff clean, 3652 passed. Astra r1: ship.