fix(syntax): make Position's Ord match Eq - #1395
Open
jaideeppyne wants to merge 1 commit into
Open
jaideeppyne wants to merge 1 commit into
jaideeppyne wants to merge 1 commit into
Conversation
Ord compared offset only while Eq was derived over offset, line, and column, so two positions could be unequal and still compare Equal. Derive Ord/PartialOrd so the total order agrees with Eq. Fixes rust-lang#1393
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`Position`'s `Ord` compared `offset` only, while `Eq` was derived over offset, line, and column. Two positions with the same offset and different line/column were unequal but compared `Equal`, which breaks `BTreeSet`/`BTreeMap`.
Derive `Ord`/`PartialOrd` so the total order agrees with equality.
Fixes #1393