Make deploy with kamal possible - #116
Open
h-m-m wants to merge 4 commits into
Open
Conversation
h-m-m
marked this pull request as ready for review
August 29, 2026 21:27
sean-dickinson
approved these changes
Aug 29, 2026
sean-dickinson
left a comment
sean-dickinson
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Could we maybe add a short markdown doc about how to deploy? Like what is required to be able to deploy and any important gotchas?
| # not contain `.rb` files, or that should not be reloaded or eager loaded. | ||
| # Common ones are `templates`, `generators`, or `middleware`, for example. | ||
| config.autoload_lib(ignore: %w[assets tasks]) | ||
| config.autoload_lib(ignore: %w[assets tasks generators]) |
Collaborator
There was a problem hiding this comment.
Q: can we revert this now or is this still needed?
Collaborator
Author
There was a problem hiding this comment.
A: I think it is still needed
Collaborator
Author
There was a problem hiding this comment.
Also I think we should discuss our options here, I have a couple ways we could improve this and I'm not sure which is best
| servers: | ||
| web: | ||
| - 192.168.0.1 | ||
| # This is a specific EC2 host that will not be usable after 2026-08-31 |
Collaborator
There was a problem hiding this comment.
Q: Why will this no longer be usable?
Collaborator
Author
There was a problem hiding this comment.
This is an outdated comment about an Ec2 instance I set up in my own account.
h-m-m
force-pushed
the
hmm/issue-62/kamal
branch
from
August 30, 2026 15:25
2694482 to
43d4f4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #62
Description
rfg2026andcreated-by: h-m-mthat was required for these changes to work.Type of change
How Has This Been Tested?
Someone in the AWS
deployersgroup who also has ssh access to an EC2 server should be able to deploy to the server by runningkamal deploy. One-time prereqs for EC2 servers are documented in Slack. We should discuss where documentation might be better located.