fix: resolve race condition in terminal initialization - #100
Closed
kanetronv2 wants to merge 1 commit into
Closed
kanetronv2 wants to merge 1 commit into
kanetronv2 wants to merge 1 commit into
Conversation
Fixes issue where users could type before prompt was displayed by: - Moving `term._initialized = true` to run after `term.prompt()` display - Maintaining performance optimizations with 100ms delay for background loading This ensures proper sequence: terminal setup → prompt display → interactive → background loading Co-authored-by: kanetronv2 <kanetronv2@users.noreply.github.com>
Contributor
|
Same story as #98 — real problem, fixed by #109 along a different path. The terminal no longer waits on Conflicts against the current files with nothing left to port, but the race you identified was real and is gone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #86
Resolves race condition where users could type before the prompt was displayed, causing input to be overwritten or appear over the prompt.
Changes:
term._initialized = trueto run afterterm.prompt()displayThe terminal cursor is now consistently responsive without the race condition.
Generated with Claude Code