Skip to content

Handle incomplete benchmark results safely - #263

Open
Daniiiil1 wants to merge 1 commit into
robotperf:mainfrom
Daniiiil1:codex/handle-invalid-benchmark-results
Open

Handle incomplete benchmark results safely#263
Daniiiil1 wants to merge 1 commit into
robotperf:mainfrom
Daniiiil1:codex/handle-invalid-benchmark-results

Conversation

@Daniiiil1

Copy link
Copy Markdown

Summary

  • avoid masking a missing benchmark result field with an UnboundLocalError
  • use the nested result mapping consistently while parsing
  • report an unknown timestamp when the timestamp itself is missing
  • add a regression test proving invalid entries are skipped and later valid results still load

Testing

  • pytest benchmarks/other/ros2benchmark/test/test_benchmark.py -q (1 passed)
  • flake8 benchmarks/other/ros2benchmark/test/test_benchmark.py
  • flake8 benchmarks/other/ros2benchmark/ros2benchmark/verb/__init__.py --select=E9,F63,F7,F82
  • python -m compileall
  • git diff --check

Signed-off-by: Daniil Mordanov mordanovdania@gmail.com

Signed-off-by: Daniil Mordanov <mordanovdania@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant