Fix: quote doxygen2docusaurus's unquoted Xref href - #27
Merged
Merged
Conversation
@xpack/doxygen2docusaurus's own \deprecated/\todo/\bug/\test renderer
(docxrefsecttype.js) emits its one cross-reference link unquoted —
`<a href=${permalink}>` instead of `<a href="${permalink}">`, the only
spot in the whole package that does this. Harmless on a site with no
spaces in its URLs; every page here lives under a path like "Adaptive
grippers", and an HTML parser ends an unquoted attribute at the first
space — so any page with one of those tags silently truncated its own
Xref link to e.g. `/docs/drivers/Adaptive`, which this build's own
broken-link check then failed on.
Surfaced from PR #26 (bumping external/2f85_cpp), whose Hand-E profile
work is the first doc comment in this repo's dependency graph to use a
`\deprecated` tag — nothing to do with this site's own content, and
latent until then. Added quoteUnquotedAnchorHrefs to
sync-external-docs.js's existing chain of doxygen2docusaurus output
fixups rather than patching node_modules.
Verified with a full npm run build + npm test against current main.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ebarnett3
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
f0c5d3ato49f56f1#26 (bumping `external/2f85_cpp`), which is the first dependency to use a `\deprecated` tag — unrelated to this site's own content.Test plan
🤖 Generated with Claude Code