Repository navigation
Add an Edit page and group the sidebar like it - #174
Merged
Merged
Conversation
…ds, Performance and Advanced Edit on the Setups page now opens one page listing every setting of the setup in the game with its current value; each row opens the pane that changes it. The page only reads the snapshot the panes already load. The sidebar follows the same groups, with an Edit entry under Setups. One-pane groups (Sounds, Mods, Performance) share a group without a heading so the sidebar still fits at 1200x800. Comfig is shown as Performance; internal ids and file names are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The Edit page only reads. It uses the snapshot the panes already load (profile detail, effective startup cfg values, mastercomfig state, saved launch options), plus
get_setup_overviewsfor the Casual setup count. Nothing the app writes has changed.Docs: CHANGELOG,
docs/guide/profiles.md(new Edit page section),docs/guide/comfig.mdand the guide index,docs/ARCHITECTURE.md.Checks
pnpm test,pnpm check,tsc --noEmitcargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warnings,cargo test --workspace --locked?preview=setups, every?preview=settings-*state,?preview=welcome, and the new?preview=settings-edit