fix(client): make retryable stream buffering abort-aware - #5801
Open
Utkarshpandey0001 wants to merge 2 commits into
Open
Utkarshpandey0001 wants to merge 2 commits into
Utkarshpandey0001 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Rivet team,
This PR fixes #5800, where
ActorHandle.fetch()could remain pending indefinitely when a streaming request body was cancelled while being buffered for lifecycle retries.Dynamic actor handles created through
get()andgetOrCreate()support retrying requests during actor lifecycle transitions. Because aReadableStreamcan normally only be consumed once, RivetKit buffers the stream before attempting the request. That buffering previously ignored the request’sAbortSignal.As a result, an already-aborted request—or a request aborted while buffering—would continue waiting for the stream to close. For long-running or open streams, the request would never settle and would never be dispatched to the actor.
What changed
Test coverage
Regression tests were added for:
getOrCreate().get().Verification
Closes #5800