Conversation
Builds the optional C extension (_rjsmin) with SETUP_CEXT_REQUIRED=1 so a compile failure is fatal instead of silently shipping a pure-Python wheel under a manylinux_riscv64 tag. No upstream CI workflow exists (rjsmin has no .github/workflows), so this follows setup.py's own build shape.
Checking out the git tag directly for cibuildwheel pulls in debug.unix.cflags, a coverage/-Werror dev-build flag file MANIFEST.in excludes from the real sdist. Its -Wdeclaration-after-statement trips on CPython 3.14's free-threaded refcount.h and fails the cp314t build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rjsmin1.2.5Compiles the optional
_rjsminC-extension accelerator behind the pure-Python JS minifier. Upstream publishes no riscv64 wheel.rjsmin ships no CI workflow at all, so this follows
setup.py's own build shape rather than mirroring a specific file.Differs from upstream
SETUP_CEXT_REQUIRED=1- upstream's own knob against silently falling back to a pure-Python wheel on a build failure.Testing
License: OK
Built on cp312; 30 passed, 0 skipped.