Add the ability to count requests #1298

Activity

1. thboileau

   added

   Module: Restlet API

   State: new

   Type: enhancement

   Version: 2.4

   on Oct 20, 2017
2. apirom9 commented on Oct 22, 2017

   

   apirom9

   on Oct 22, 2017

   More actions

   I see. May be we can

   • define some interfaces in the core module
   • add some setter for instance of those interfaces in the main class of core module such as org.restlet.Application
   • create new sub module with classes implement those interfaces and we add dependency to 3rd party library (such as dropwizard) to this sub module instead of core module

   Just an idea. Sorry, I don't have lot of experience in design java application.
3. Tembrel commented on Jan 30, 2018

   

   Tembrel

   on Jan 30, 2018

   Collaborator

   More actions

   Using the application name to register the counter is probably not a good idea, since nothing prevents two applications from sharing a name.

   Why not just offer this as a standalone class, possibly in an extension, with one public static method that application writers can use as follows:

   public class MyApplication extends Application {
       @Override public Restlet createInboundRoot() {
           Router router = new Router(getContext());
           ... wire things up with router ...
           return Metrics.withCounter(router, "my counter name");
   }
   

   I don't see a compelling need for deeper integration.