Expose WebSocket upgrade context to handshake validation - #406
Merged
Conversation
jackyzha0
approved these changes
Sep 2, 2026
Armster15
added a commit
that referenced
this pull request
Sep 2, 2026
## Why River 0.222.0 includes the WebSocket connection extras API from #406. This prepares that change for publication to npm. Original conversation: https://replit.slack.com/archives/D0AEJNMGCSG/p1788333765717319 ## What changed Bumps the `@replit/river` package version from 0.221.0 to 0.222.0 in `package.json` and `package-lock.json`. This PR does not change source code or dependencies. ## Test plan - `npm run check` - `npm run test:single` (785 passed, 1 skipped) - `npm run build` ## Versioning - [ ] Breaking protocol change - [ ] Breaking ts/js API change ~ written by Zerg 馃懢 ([volatile-queen-8e97](https://zerg.zergrush.dev/chat?id=volatile-queen-8e97))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
River already stores WebSocket upgrade headers in
connection.extras, but server handshake validation cannot read them. A downstream gateway authenticates a session cookie during WebSocket upgrade and needs to pass the verified identity tovalidate.What changed
Server handshake validation now accepts one optional argument:
River passes the extras from the current connection at both validation sites:
WebSocketServerTransportalso accepts an optional fourth constructor argument:The default behavior is unchanged. Without a factory, River stores the same cleaned upgrade headers that it stores today. The factory is synchronous because River must install the socket message handler during the connection event. Applications can finish asynchronous authentication before this event and let the factory read the verified result.
Existing three-argument
validatefunctions still compile and work. This PR does not change protocol messages or package versions. The typing and tests follow the precedent in #403. The README now documents the new validator argument, factory, and synchronous constraint.Test plan
npm run checknpm run test:single(785 passed, 1 skipped)npm run buildnpx prettier README.md --checkVersioning
~ written by Zerg 馃懢 (volatile-queen-8e97)