Conversation
date '+%-d.%-m.%Y' produced 17.9.2026 where the cookie convention is dd.mm.yyyy, and the call ran in whatever locale the builder had.
Two things came out of one string. The cookie carried the git describe
where Version looks for <version>.<revision>, and rt_IdString pointed at
the cookie itself, "$VER: " and all, which a ROMTag has no use for.
Before, on the v0.7.0 release build:
> version CD0:
ODFileSystem 0.-1
> version CD0: full
ODFileSystem 0.-1
> version L:ODFileSystem
ODFileSystem v0.7.0 (28.7.2026)
> version L:ODFileSystem full
ODFileSystem v0.7.0 (28.7.2026)
> version ODFileSystem
ODFileSystem 0.-1
> version ODFileSystem full
ODFileSystem 0.-1
ROMTag: "$VER: ODFileSystem v0.7.0 (28.7.2026)"
Suggested change: the numbers go into that position and the describe
follows the date, so every reader parses it and none of them lose the
describe:
> version L:ODFileSystem
ODFileSystem 0.7
> version L:ODFileSystem full
ODFileSystem 0.7 (17.9.2026)
v0.7.0-12-g2e6d42b
> version ODFileSystem
ODFileSystem 0.7
> version ODFileSystem full
ODFileSystem 0.7 (17.9.2026)
v0.7.0-12-g2e6d42b
> version CD0:
ODFileSystem 0.7
> version CD0: full
ODFileSystem 0.7 (17.9.2026)
v0.7.0-12-g2e6d42b
ROMTag:
ODFileSystem 0.7 (17.9.2026)
v0.7.0-12-g2e6d42b
rt_IdString and the FileSysResource entry name point past the prefix and
share that one string, so the separate creator string is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things came out of one string. The cookie carried the git describe where Version looks for ., and rt_IdString pointed at the cookie itself,
$VER:and all, which a ROMTag has no use for.Before, on the v0.7.0 release build:
Suggested change: the numbers go into that position and the describe follows the date, so every reader parses it and none of them lose the describe:
rt_IdString and the FileSysResource entry name point past the prefix and share that one string, so the separate creator string is gone.