docs: file the problem code changes under Unreleased - #975
Merged
Conversation
The two problem-code entries were written while their work was still unreleased, and the branch landed on main after the v0.29.0 release commit. Rebasing carried them into the section the release commit had just renamed, so the changelog credits v0.29.0 with changes the v0.29.0 tag does not contain. The published v0.29.0 client exposes no `refusalCode`, and the problem table entry for `action.evidence_failed` was added after the tag. Move both entries and their evidence anchors to Unreleased. The bare attachment disposition entry stays in v0.29.0: that one shipped. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jeremi
enabled auto-merge (rebase)
September 10, 2026 04:26
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2bc1c9bca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves two changelog entries, and their evidence anchors, from
## v0.29.0 beta-41to## Unreleased:action.refusedproblemaction.evidence_failedWhy
Both entries were written while the work in #972 was unreleased. #972 landed on main after the v0.29.0 release commit, and the rebase carried the entries into the section the release commit had just renamed from
Unreleasedtov0.29.0 beta-41. None of #972's commits are ancestors of thev0.29.0tag, so the changelog currently credits v0.29.0 with changes it does not contain.The effect is not cosmetic. A reader who installs v0.29.0 and looks for the typed refusal will not find it:
@registrystack/client@0.29.0on npm exposes norefusalCode, and theaction.evidence_failedrow was added to the published problem table after the tag was cut.The bare
attachmentdisposition entry stays where it is. That change came from #970 and did ship in v0.29.0.Verification
check:evidence-anchors(386 anchors, 1226 cited paths, 919 cited symbols),check:evidence-links(72 links),check:markdownandcheck:styleall pass. The diff moves 24 lines and changes no wording.