Repository navigation
fix(coordinator): state what omitting onDeclaredRefusal means - #2065
Merged
Merged
Conversation
…no edge The snapshot of a call that omits the refusal edge carries no onDeclaredRefusal member, so existing snapshots stay byte-identical. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
An optional member with no default says what leaving it out does. Without the edge a declared refusal fails the run with product-refused, like every other refusal. The project schema is regenerated. Refs #1988 Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
2 tasks done
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main already routes a validated declared BReg action refusal through
onDeclaredRefusal(landed with #2040), including the guard that keeps refusal-shaped problems outside the typed contract uncertain. The one gap left from #1988 was the contract for the other side: what happens when a call does not author the edge. This PR pins and documents it.tests/authored_project.rs: a call withoutonDeclaredRefusalfreezes no refusal edge.authoring.rsdoc comment,PRODUCT-CONTRACT.md,README.md: omittingonDeclaredRefusalfails the run withproduct-refused, like any other refusal.generated/project/project.schema.json: regenerated from the doc comment withcargo run --locked -p registry-coordinator --features schema --example project-schema -- --output products/coordinator/generated/project.coordinator-configuration.mdx: the same sentence, with an evidence anchor todeclared_refusal_without_an_authored_edge_preserves_refused_behavior.Note: #1988 names the field
onRefused; main shipsonDeclaredRefusal, and this PR keeps that name.Supersedes #2029, whose branch stacked on the pre-squash #2040 history.
Verification
cargo fmt --check,cargo clippy -p registry-coordinator --all-targets -- -D warnings,cargo test --locked -p registry-coordinator(non-PostgreSQL targets)products/coordinator/scripts/check-schemas.sh,python3 products/coordinator/scripts/check_dependency_direction.py, coordinator Python script tests.gitleaks.toml: no leaksNot run locally: the Coordinator PostgreSQL suite. The existing refusal test
declared_refusal_is_checkpointed_and_prior_uncertainty_cannot_take_its_branchruns in this PR's "Coordinator PostgreSQL runtime" job.Closes #1988