Repository navigation
[perf] Key config by old name in Arguments/Removing rules - #8743
Merged
Merged
Conversation
RemoveMethodCallParamRector, ArgumentAdderRector and ArgumentRemoverRector each scanned their whole configured value-object list per visited node, running isName() on each entry before the object-type check. Bucket the list by lowercased old method name once in configure(). RemoveFuncCallRector flips its flat function-name list to a lowercased name set. The lowercased key matches the case-insensitive isName() lookup these rules already used, so behaviour is unchanged. bench/remove_method_call_param_bucket_bench.php (400 entries, 200 non-matching calls): 1000.6 -> 1.8 us/call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch C of the configurable-rule config-scan cleanup (follows #8734 / #8735 / #8736 / #8739 / #8742). Four Arguments/Removing rules scanned their whole configured list per visited node, running
isName()on each entry.RemoveMethodCallParamRectorArgumentAdderRectorArgumentRemoverRectorRemoveFuncCallRectorisset)Each builds a bucket keyed by lowercased old method name once in
configure();RemoveFuncCallRectorflips its flat name list to a lowercasedarray<string,true>set. Any object-type / class-type check stays inside the matched branch. The lowercased key matches the case-insensitiveisName()these rules already used, so behaviour is unchanged.Numbers
bench/remove_method_call_param_bucket_bench.php(400 entries, 200 non-matching calls, CPU time):Scales with configured-list size. Full
rules-tests/Arguments+rules-tests/Removing(33 tests) green, PHPStan and ECS clean.