Repository navigation
[perf] Speed up legacy Php rules with cheap guards before reflection and type lookup - #8672
Open
TomasVotruba wants to merge 1 commit into
Open
TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance refactor of 5 rules. No behavior change - all fixtures pass unchanged.
SensitiveConstantNameRector(Php73) - the already-uppercase check and the special-characterstr_containsbails now run beforereflectionProvider->hasConstant(); since most constant names are already uppercase, the reflection lookup is skipped in the common case.ExportToReflectionFunctionRector(Php74) - the first-argument presence check now runs beforegetType($node->class).IsIterableRector(Php71) -shouldSkip()now checks the PHP version beforereflectionProvider->hasFunction()(semantically identical, skips the function reflection lookup when the version already providesis_iterable).RemoveExtraParametersRector(Php71) -isFirstClassCallable()now runs before resolving the function/method reflection.ThisCallOnStaticMethodToStaticCallRector(Php70) -isFirstClassCallable()now runs beforestaticAnalyzer->isStaticMethod().Reordering is safe: all moved checks are side-effect-free bail conditions that must all pass to proceed.