Repository navigation
[perf] Speed up CodeQuality rules with cheap guards before type resolution, reflection and subtree walks - #8664
Merged
Conversation
…ution, reflection and subtree walks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance refactor of 7 rules. No behavior change - all fixtures pass unchanged.
Each rule ran an expensive op (type resolution, reflection, or a node-finder subtree walk) before a cheap check that can bail first:
ThrowWithPreviousExceptionRector-isFirstClassCallable()now runs beforeresolveExceptionArgumentPosition()(reflection).RepeatedOrEqualToInArrayRector- theEqualnode walk is now done lazily inside the$identicals !== []branch (its only use), so an expression with noIdenticalskips it.RepeatedAndNotEqualToNotInArrayRector- same, theNotEqualwalk is done only when$notIdenticalsis non-empty.SimplifyEmptyCheckOnEmptyArrayRector- the allowed-expression instanceof check now runs before$scope->getType().IssetOnPropertyObjectToPropertyExistsRector- theArrayDimFetchbail now runs beforeshouldSkipForPropertyTypeDeclaration()andmatchPropertyTypeClassReflection()(reflection + getType).TernaryEmptyArrayArrayDimFetchToCoalesceRector- theareNodesEqual()comparison now runs beforegetType().InlineIsAInstanceOfRector- the second argument shape (Variable / ClassConstFetch) is checked beforeisFirstObjectType()(getType).Reordering is safe: all moved checks are side-effect-free bail conditions, and each lazily-computed value is used only in the branch it was moved into.