Repository navigation
[perf] Speed up array_map/array_reduce closure param rules with cheap Closure arg bail before reflection - #8657
Merged
Conversation
… with cheap Closure arg bail before reflection
TomasVotruba
changed the title
TomasVotruba
enabled auto-merge (squash)
October 15, 2026 10:47
TomasVotruba
disabled auto-merge
October 15, 2026 10:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance refactor of
AddClosureParamTypeForArrayMapRectorandAddClosureParamTypeForArrayReduceRector. No behavior change - all fixtures pass unchanged.Both rules resolved the function reflection via
resolveFunctionLikeReflectionFromCall()before checking that the closure argument is actually aClosurenode. That reflection resolution was paid even for the common cases where the callback is a string callable or an arrow function, which can never match.The cheap structural guard (closure arg present and is a
Closure) is now hoisted above the reflection call. Both conditions are required anyway, so reordering is safe; reflection is only resolved once the closure arg is confirmed.